[v18.x] lib: drop fetch experimental warning#45628
Closed
Richienb wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
[v18.x] lib: drop fetch experimental warning#45628Richienb wants to merge 1 commit intonodejs:v18.x-stagingfrom
Richienb wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#45287 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
added
needs-ci
styfle
approved these changes
Nov 28, 2022
Member
styfle
left a comment
styfle
left a comment
There was a problem hiding this comment.
Thanks!
I also think the docs need to be updated since those still stay experimental here: https://nodejs.org/api/globals.html#fetch
Contributor
Author
I believe this also applies to the verison this pr is based on too. I believe documentation updates are an upstream problem and should be done there first in the main branch. |
Member
|
Sounds good! I created a PR: #45684 |
Collaborator
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #45287 by cherry-picking the commit.